Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lttoolbox monodix compiler #504

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

mr-martian
Copy link
Contributor

Currently unimplemented features:

  • <re>
  • language variants

@TinoDidriksen TinoDidriksen self-requested a review March 21, 2021 14:30
@mr-martian
Copy link
Contributor Author

I believe all that remains now is to implement language variants (which should just be a matter of storing the strings from the command line and then comparing them with property values) and then figuring out how to verify that this is, in fact, equivalent to lt-comp.

@mr-martian
Copy link
Contributor Author

Two issues:

  • I'm inclined to not implement ACX support directly in this, since that would involve entirely duplicating the code in hfst-expand-equivalences
  • I need to rename lt-proc's -v/--variant since it conflicts with the default -v/--verbose

@mr-martian
Copy link
Contributor Author

ok, so if I run it on apertium-eng.eng.dix it runs out of memory and crashes, but if I run it on smaller things it does fine. Further investigation required.

@mr-martian
Copy link
Contributor Author

Turns out the issue was forgetting to move on to the next character after reading a | in a regex.

@mr-martian mr-martian marked this pull request as ready for review April 5, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant