-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require C 11 or even C 1y #407
Comments
Generating binary wheels for Mac requires OS X version 10.6 which doesn't support c 11. I don't remember exactly why 10.6 was required. I think pip didn't accept packages that used 10.7 and started to compile everything from scratch. Also, compiling binary wheels for python 2 for Windows requires using a c compiler that doesn't support c 11. (Although I'm not sure if we need to support python 2.) I couldn't find a solution to this problem so I decided just to write an alternative implementation for those places in code where c 11 features were used. |
Ergh. I think it's time to drop Python 2 support then. As https://pythonclock.org/ says, Python 2.7 will not be maintained past January 1st, 2020. |
Ah, well I guess that solves the problem with python 2 support for Windows then. But the issue of generating binary wheels for Mac is still there. (OS X version 10.6 is required for all versions of python.) |
Google hits show other people using C 11 with Python3 on macOS. And it wouldn't make sense for C 11 to be a problem, given Python's API is C. The only issue I can find is https://docs.brew.sh/C -Standard-Libraries which only matters for installations upgraded through the years - fresh installs link against the C 11-capable libc . |
Now that I try to install the bindings on Mac with python 3.6, everything seems to work when c 11 is used (and OS X 10.7 is required in the wheel). Last time I tried, pip refused to install the wheel. Maybe it was the old pypi server or old version of pip. |
I only just noticed 318fdb5 and I strongly object to it.
What platform is that desired for? I see that the
#ifdef
references_MSC_VER
but that's wrong - the freely available version of Visual Studio supports much newer standards, even going back a few releases. And the new compilers can target older platforms.For comparison, hfst-ospell, Apertium and CG-3 all require C 1y (pre-standard C 14).
The text was updated successfully, but these errors were encountered: