-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the DNS name limit #8384
Conversation
2bee5ea
to
178705b
Compare
Signed-off-by: Renato Suero <[email protected]>
178705b
to
5aae094
Compare
According to the Kubernetes docs, some resource names have a max length of 63 characters while others have a max length of 253 characters. I'm trying to figure out which objects have the 63 character length right now. It appears that Containers, Namespaces, Service Ports, Volumes, CSI Drivers and EndpointPorts are all limited to 63 character names. Charts will occasionally create namespaces. How should this be handled? |
ping. |
Sorry busy days. I checked in the kubernetes code, I found label and job has the limitation. Regarding how to should this be handled, maybe we could check the resource and apply the correct limit, what do you think @mattfarina ? |
The fixed max length releaseName may face a special case: secret name max length limitation is 253. the release name length is 231, the secret name length is 253 equally, and then upgrade the release to version 10, the computed secret name length could be 254, which is not satisfied with kubernetes object name spec. |
@liuming-dev, I didn't get your point. the 231 value was calculated here. Could you explain your point |
For example: Another point need to be noticed, release name is used in release secret label, that means its length should not be more than 63 characters. |
thanks @liuming-dev I got your point now. what do you suggest to fix that? |
ping |
@renatosuero This potential issue here is that not all Kubernetes resources are max character length. Some charts name resources using the release name. Have you investigated all Kubernetes resource/object name sizes? |
@hickeyma I'll double check again, but If I'm not wrong the labels are the only one which still have 63 chars |
@renatosuero as a suggestion, you could write unit tests to generate kubernetes resources using Have a look at the kubernetes test infrastructure for ideas. |
Any updated? |
closing as inactive. If someone wants to carry on the work and address some of the other maintainer's comments, feel free. |
@bacongobbler |
Signed-off-by: Renato Suero [email protected]
closes #6006
What this PR does / why we need it:
I've increased the limit for resource naming. The project was using 63(the value for Kubernetes version 1.4) now the new value is 253.
Special notes for your reviewer:
If applicable: