Increase column width when listing releases #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow issue:) repository.
|
|
This change is |
k8s-ci-robot
added
the
cncf-cla: no
|
Looks good. As soon as the LF CLA passes I will merge. |
|
In theory, the CLA should now be in order. I guess it tries checking again after a comment..? |
|
Or do I have to push a new commit? |
k8s-ci-robot
added
cncf-cla: yes
|
Thank you! I'm merging this into 2.1 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Second attempt with correct author.email)
After #1560 was merged, names of releases can now be up to 53 characters long, up from 14 previously. When listing releases, the maximum column width is 30 characters, meaning it's not possible to get the full name of releases using the full available length.
This change just increases the maximum column width to 60, to allow for longer release names.
PS.
I'm working on getting a CLA signed by my employer, even if it does seem a bit silly for such a small change. :)