-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to add extra objects and resources when installing a Helm chart #12653
Comments
Before I dig in further, why wouldn't the extra objects be a second chart someone installs that add those? Consider package managers for other platforms (like Linux) installing something like PHP or ffmpeg. For the "additional" parts there are secondary packages one would install. Why wouldn't that same style experience be followed? |
My understanding is that users find it laborious to create and maintain a second chart. There is an example of this in traefik/traefik-helm-chart#595 (comment) and apache/couchdb-helm#72 (comment) where @colearendt wrote:
|
@wallrj, you forgot to mention this: fluent/helm-charts#331 😉 |
I think that Helm is currently lacking documentation & conventions (and maybe some tooling) to correctly separate the various roles who interact with it; this has led to charts trending towards having fewer constraints and being less opinionated. The addition of the This said I can see value in adding native Helm support for rendering external templates as part of a chart install. I think the wrapper chart pattern is a better solution but anything to help move away from the IMHO a public Helm chart (for a component) should aim to be as opinionated as possible while following the open-closed principal. |
@wallrj Also, this is related kubernetes/autoscaler#5633 |
@mattfarina are you persuaded by the reasons given in the comments above? |
New use case: kubernetes/ingress-nginx#11351 (Always me 😛) |
This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs. |
This feature is still needed. |
Another addition to the topic: kubernetes/autoscaler#7243 |
In cert-manager/cert-manager#5900 @pierluigilenoci and I have been discussing whether it is sustainable for each Helm chart to implement its own
values.extraObjects
field.Judging by the number of popular charts that have added
extraObjects
, this is clearly a needed feature.Some use cases are:
I think this should be implemented in Helm, probably as a
helm install
command line option, for the following reasons:helm install --user-supplied-manifests extra-objects/
, than to addValues.extraObjects
to each Helm chart.helm install --user-supplied-manifests extra-objects/
, than for each Helm chart to implement the feature slightly differentlyhelm install --user-supplied-manifests extra-objects/
thoroughly at helm.sh, than to document it (or not document it) chart-by-chart in the chart README file, for example.Links of interest, in no particular order:
extraObjects
value that allows creating supportive / adhoc resources traefik/traefik-helm-chart#595.Values.extraObjects
aws/karpenter-provider-aws#3803extraObjects
value that allows creating supportive / adhoc resources apache/couchdb-helm#72extraObjects
example influx2/values.yaml
doesn't appear to work. fluxcd-community/helm-charts#183Originally posted by @wallrj in #7077 (comment)
The text was updated successfully, but these errors were encountered: