Macros #1234
Macros #1234
Conversation
|
Looks like the CI had a submodule fetch failure. |
|
I want to add recording status to the statusline but I don't think I am able to access it from the |
`helix_term::compositor::Callback` changed to take a `&mut Context` as a parameter for use by `play_macro`
When macro recording is active, the pending keys display will be shifted 3 characters left, and the register being recorded to will be displayed between brackets — e.g., `[@]` — right of the pending keys display.
|
I think this should be done now. |
| let reg = cx.register.take().unwrap_or('@'); | ||
| cx.editor.macro_recording = Some((reg, Vec::new())); | ||
| cx.editor | ||
| .set_status(format!("Recording to register {}", reg)); |
There was a problem hiding this comment.
Does our macro reuse the same register as the normal registers? IIRC vim macros have separate registers.
There was a problem hiding this comment.
We reuse the normal register since that means you can edit the macro as text (paste it in the buffer, edit, yank it back). I think vim also allowed for that
There was a problem hiding this comment.
Vim macros do not have separate registers.
| "q" => record_macro, | ||
| "Q" => play_macro, |
There was a problem hiding this comment.
I think this should be the reverse, Q should record macro and q should play macro like in vim.
Since it's a macro, it's expected to play more than record. And since play is expected to be used more frequently, it would be best use without extra shift.
There was a problem hiding this comment.
Good point, kakoune has this as well. I didn't realize it during review
There was a problem hiding this comment.
In Vim, record is q and play is @; I changed it here because I figured it's more consistent. But yeah, swapping q and Q here does make sense.
There was a problem hiding this comment.
(it's also "replay" instead of "play" but I didn't have strong opinions there)
There was a problem hiding this comment.
Oh, yeah sorry if I get stuff inconsistent with Kakoune, I've never used it and am not very familiar with it. Though in this situation, I do believe "play" makes very slightly more sense than "replay", since it is possible to play a macro without actually recording it, in which case playing it would not be a "replay".
| .get(reg) | ||
| .and_then(|reg| reg.read().get(0)) |
There was a problem hiding this comment.
We can just use cx.editor.registers.read(reg) helper.
qwill begin recording to register@"aqwill begin recording to registeraqwhile recording will stop recording and save to the registerQwill play the recording from register@"aQwill play the recording from registeraMacros are saved to registers as space-delimited serialized keypresses, such as
x d o 0 esc h C-a.I've had to change
helix_term::compositor::Callbackto take&mut Contextas a parameter so thatplay_macrowould have access to thehandle_eventmethod.