Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting wrong images if tagged more than once #8

Closed
derwebcoder opened this issue Sep 4, 2017 · 2 comments
Closed

Deleting wrong images if tagged more than once #8

derwebcoder opened this issue Sep 4, 2017 · 2 comments

Comments

@derwebcoder
Copy link
Contributor

cleanreg deletes images which are tagged twice, even if setting --ignore option. Looks like --ignore is only checking for duplicates in the same repository.

Having an image example-a:test-123 and tagging it additionally example-b:test-123. Both will have the same digest. Running cleanreg for example-b and deleting the image, it will also delete example-a, even if --ignore option has been set.
@hcguersoy
Copy link
Owner

hcguersoy commented Sep 6, 2017 •
edited
Loading

There is some discussions about this in the docker distribution project, somehow a bit unstrucutured. see distribution/distribution#2170

hcguersoy added a commit that referenced this issue Sep 11, 2017
@hcguersoy
fix for #8
d1f2264
@hcguersoy
Copy link
Owner

Should be fixed with the commit above. Please check version 0.5.0 if it is OK now. I've added some new tests too, to be sure that we cover this but just wondering why the tests before run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hcguersoy @derwebcoder