Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAST 4.2 support #5

Open
myslak71 opened this issue Jan 8, 2021 · 4 comments
Open

VAST 4.2 support #5

myslak71 opened this issue Jan 8, 2021 · 4 comments

Comments

@myslak71
Copy link

myslak71 commented Jan 8, 2021

Hello!
I've checked https://github.com/haxqer/vast/issues/1 and wanted to ask when do you plan to support VAST 4.2?

Thank you!

@haxqer
Copy link
Owner

haxqer commented Jan 12, 2021

https://github.com/haxqer/vast/tree/4.2

Thank you!

@Momotoculteur
Copy link

Hey :)

Thanks in advance for your lib !

But in the main branch, i cannot validate any xml file with his corresponding 4.2xsd file ( tested with libxmljs2 & xmllint) https://github.com/InteractiveAdvertisingBureau/vast/blob/master/vast_4.2.xsd

this is about changes between 4.1 and 4.2 with xs:all replace by xs:sequence, which mean presence of somes props and with a specific order ; i'm talking especially about UniversalAdID prop. Seems great on you're 4.2 branch, but i get others validation errors. Could you merge 4.2 branch with latest commit of master branch ?

Have a great day,
Bastien

@haxqer
Copy link
Owner

haxqer commented Feb 21, 2022

Hi Bastien :)

Thank you very much.

I'm busy with my new job and don't have time to deal with it at the moment.
I'll deal with it next month.

My apologies,
Haxqer

@rdgordon-index
Copy link

#12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants