Fix for #664, crashed due to ig.Attachements being 0 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,7 60,11 @@ func resourceAwsInternetGatewayRead(d *schema.ResourceData, meta interface{}) er | |||
| } | |||
|
|
|||
| ig := igRaw.(*ec2.InternetGateway) | |||
| d.Set("vpc_id", ig.Attachments[0].VpcId) | |||
| if len(ig.Attachments) == 0 { | |||
| d.SetId("") | |||
There was a problem hiding this comment.
By setting the ID of this resource to an empty string, you will create a dangling resource. The Internet Gateway will still exist, but after resetting the ID Terraform will think it doesn't and will drop any references to this resource from it's state file.
What you actually want to do here is clear the vpc_id. If you set the vpc_id to an empty string, the resource will understand that the Internet Gateway still exists, but is not attached to a VPC. This way you can keep managing the Internet Gateway and attach it to another VPC (or choose to properly delete the resource) if you want/need to.
There was a problem hiding this comment.
Thanks for clarifying, makes total sense. Updated the PR!
armon
added a commit
that referenced
this pull request
Dec 15, 2014
Fix for #664, crashed due to ig.Attachements being 0
|
Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #664