Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overly-eager jsonencode #35984

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Fix overly-eager jsonencode #35984

merged 3 commits into from
Nov 13, 2024

Conversation

bplotnick
Copy link
Contributor

@bplotnick bplotnick commented Nov 11, 2024 •
edited by radeksimko
Loading

Fixes #35983

Target Release

1.9.9

Draft CHANGELOG entry

BUG FIXES

  • Simplify config generation (plan -generate-config-out) for string attributes that contain primitive types (e.g. numbers or booleans)

@bplotnick bplotnick requested a review from a team as a code owner November 11, 2024 16:54
@crw
Copy link
Collaborator

crw commented Nov 11, 2024

Thanks for this submission, I'll raise it in triage.

@crw crw added the bug label Nov 11, 2024
radeksimko
radeksimko approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Thanks for the PR.

internal/genconfig/generate_config_test.go Outdated Show resolved Hide resolved
@radeksimko radeksimko added the 1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Nov 13, 2024
@radeksimko radeksimko merged commit de69c22 into hashicorp:main Nov 13, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
1.10-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config generation wraps numbers and booleans in jsonencode
3 participants
@bplotnick @crw @radeksimko