Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init -from-module #16487

Merged
merged 2 commits into from
Oct 30, 2017
Merged

init -from-module #16487

merged 2 commits into from
Oct 30, 2017

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Oct 27, 2017

Add GetModule for the cli to initialize from a regisry module source.

Storage.GetModule fetches a module using the same detection and
discovery as used by the normal module loading. The final copy is still
done by module.GetCopy to remove vcs files.

Add GetModule for the cli to initialize from a regisry module source.

Storage.GetModule fetches a module using the same detection and
discovery as used by the normal module loading. The final copy is still
done by module.GetCopy to remove vcs files.
This will enable copying any module source into a target directory.
Copy link
Contributor

@apparentlymart apparentlymart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It'd also be good to add a TF_ACC-blocked test to the command/e2etest suite that installs something from the real registry just as a final validation that this is all working end-to-end, since we're going to start describing this as part of the getting started guide section on modules when we introduce the module registry and so this workflow will get more prominent.

@jbardin
Copy link
Member Author

jbardin commented Oct 30, 2017

I'll push the the e2e test in a separate PR.

@jbardin jbardin merged commit 90a7c7a into master Oct 30, 2017
@ghost
Copy link

ghost commented Apr 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants