provider/heroku: enable TestAccHerokuSpace_Basic to pass with new Heroku Organization #15191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nv var for the TestAccHerokuSpace_Basic test
|
👍 🎉 |
radeksimko
approved these changes
Jun 8, 2017
|
|
vanstee
pushed a commit
to vanstee/terraform
that referenced
this pull request
Sep 28, 2017
…nv var for the TestAccHerokuSpace_Basic test (hashicorp#15191)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroku has kindly created a special organization on their end and added our test account to it. Using this organization, we can now test the Heroku Provider's support for Heroku Spaces. Here I add super for a special env var
HEROKU_SPACES_ORGANIZATIONtheTestAccHerokuSpace_Basictest. This allows all our existing tests to use our existing organization, and only run this specific test in the new organization.Thanks to @danp and others for making it happen 😄
Waiting on tests to pass, but I've added support for this to our internal CI