Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task_parameters parameter to aws_ssm_maintenance_window_task resource #15104

Merged
merged 2 commits into from
Jun 6, 2017
Merged

Add task_parameters parameter to aws_ssm_maintenance_window_task resource #15104

merged 2 commits into from
Jun 6, 2017

Conversation

joelthompson
Copy link
Contributor

This adds support for task_parameters to the aws_ssm_maintenance_window_task resource.

The ssm:RegisterTaskWithMaintenanceWindow AWS API method includes a TaskParameters parameters, which isn't currently supported by TF. This adds support that parameter.

Additionally, the docs had an incorrect name for the aws_ssm_maintenance_window's allow_unregistered_targets parameter (it was actually allow_unassociated_targets in the TF resource and the AWS API), so updating the doc to correct the name for that.

Joel Thompson added 2 commits May 25, 2017 03:15
Add task_parameters support to aws_ssm_maintenance_window_task
107b19a 
task_parameters weren't supported yet. This adds support for them. It
also corrects a documentation typo in the maintenance_window resource.
Respond to internal feedback
ee99b4e
@stack72
Copy link
Contributor

stack72 commented Jun 6, 2017

This LGTM! Thanks for this and also for picking up the error in our docs

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMMaintenanceWindowTask'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/06 14:05:52 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMMaintenanceWindowTask -timeout 120m
=== RUN   TestAccAWSSSMMaintenanceWindowTask_basic
--- PASS: TestAccAWSSSMMaintenanceWindowTask_basic (205.53s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	205.554s

Paul

@stack72 stack72 merged commit 1812ce2 into hashicorp:master Jun 6, 2017
@joelthompson
Copy link
Contributor Author

Thanks for responding so quickly! :)

@joelthompson joelthompson deleted the add_ssm_task_parameters branch June 6, 2017 13:35
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelthompson @stack72