Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/google: Update health check tests #15102

Merged
merged 3 commits into from
Jun 6, 2017
Merged

provider/google: Update health check tests #15102

merged 3 commits into from
Jun 6, 2017

Conversation

rileykarson
Copy link
Contributor

Like the tests in #15101, all 3 health check resources were not performing updates in their update tests.

@danawillow

@stack72
Copy link
Contributor

stack72 commented Jun 6, 2017

Hi @rileykarson

Thanks for updating these tests :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeHealthCheck'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/06 15:08:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeHealthCheck -timeout 120m
=== RUN   TestAccComputeHealthCheck_tcp
--- PASS: TestAccComputeHealthCheck_tcp (24.68s)
=== RUN   TestAccComputeHealthCheck_tcp_update
--- PASS: TestAccComputeHealthCheck_tcp_update (36.41s)
=== RUN   TestAccComputeHealthCheck_ssl
--- PASS: TestAccComputeHealthCheck_ssl (23.84s)
=== RUN   TestAccComputeHealthCheck_http
--- PASS: TestAccComputeHealthCheck_http (23.83s)
=== RUN   TestAccComputeHealthCheck_https
--- PASS: TestAccComputeHealthCheck_https (23.96s)
=== RUN   TestAccComputeHealthCheck_tcpAndSsl_shouldFail
--- PASS: TestAccComputeHealthCheck_tcpAndSsl_shouldFail (0.01s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	132.742s

Paul

@stack72 stack72 merged commit 0523ccf into hashicorp:master Jun 6, 2017
@danawillow danawillow mentioned this pull request Feb 27, 2023
Closed
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/google-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileykarson @stack72 @radeksimko