Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/alicloud: Fix vpc and vswitch bugs while creating vpc and vswitch #15082

Merged
merged 1 commit into from
Jun 5, 2017
Merged

provider/alicloud: Fix vpc and vswitch bugs while creating vpc and vswitch #15082

merged 1 commit into from
Jun 5, 2017

Conversation

xiaozhu36
Copy link
Contributor

This PR fixed the vpc and vswitch bugs that there will raise error when creating multiple vpc or vswitch simultaneously, and the PR using retry to solve them.

The running results of vpc and vswitch testcase as follows:

TF_ACC=1 go test ./alicloud -v -run=TestAccAlicloudVpc -timeout 120m=== RUN TestAccAlicloudVpc_basic
--- PASS: TestAccAlicloudVpc_basic (20.17s)
=== RUN TestAccAlicloudVpc_update
--- PASS: TestAccAlicloudVpc_update (34.13s)
PASS
ok github.com/alibaba/terraform-provider/alicloud 54.323s

TF_ACC=1 go test ./alicloud -v -run=TestAccAlicloudVswitch -timeout 120m
=== RUN TestAccAlicloudVswitch_basic
--- PASS: TestAccAlicloudVswitch_basic (30.97s)
PASS
ok github.com/alibaba/terraform-provider/alicloud 30.982s

@stack72
Copy link
Contributor

stack72 commented Jun 5, 2017

Hi @xiaozhu36

Thanks for this - LGTM!

% make testacc TEST=./builtin/providers/alicloud TESTARGS='-run=TestAccAlicloudVpc'                                                          ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/05 20:16:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/alicloud -v -run=TestAccAlicloudVpc -timeout 120m
=== RUN   TestAccAlicloudVpc_basic
--- PASS: TestAccAlicloudVpc_basic (65.57s)
=== RUN   TestAccAlicloudVpc_update
--- PASS: TestAccAlicloudVpc_update (107.86s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/alicloud	173.436s
[stacko@Pauls-MacBook-Pro:~/Code/go/src/github.com/hashicorp/terraform on xiaozhu36-vpc-vsw-bug]
% make testacc TEST=./builtin/providers/alicloud TESTARGS='-run=TestAccAlicloudVswitch'                                                      ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/05 20:21:50 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/alicloud -v -run=TestAccAlicloudVswitch -timeout 120m
=== RUN   TestAccAlicloudVswitch_basic
--- PASS: TestAccAlicloudVswitch_basic (100.71s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/alicloud	100.732s

@stack72 stack72 merged commit 0b63007 into hashicorp:master Jun 5, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaozhu36 @stack72