provider/openstack: Add to support protocols for resourceNetworkingSecGroupRuleV2 #14307
Conversation
takaishi
changed the title
There was a problem hiding this comment.
@takaishi Thanks for submitting this. I just have a few style requests for the name of the test.
In addition, would it be possible for you to rename the first commit to:
vendor: Updating Gophercloud for OpenStack Provider
Let me know if you need help with that or if you have any questions. :)
| @@ -85,6 85,115 @@ func TestAccNetworkingV2SecGroupRule_timeout(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccNetworkingV2SecGroupRule_vrrp(t *testing.T) { | |||
There was a problem hiding this comment.
I think we should change the test name to something like TestAccNetworkingV2SecGroupRule_protocols since it's testing more than just VRRP.
| @@ -226,3 335,154 @@ resource "openstack_networking_secgroup_rule_v2" "secgroup_rule_2" { | |||
| } | |||
| } | |||
| ` | |||
|
|
|||
| const testAccNetworkingV2SecGroupRule_vrrp = ` | |||
There was a problem hiding this comment.
Similarly here, testAccNetworkingV2SecGroupRule_protocols.
|
@jtopjian Thank you for comment! |
|
@takaishi Thanks! Nice work on this, thank you very much :) |
|
This fix doesn't address the case where the protocol is supplied by a protocol number (because eg you're stuck using an older version of neutron). This still results in 'null' being handed to the API backend resulting in an 'any' protocol rule being created, in spite of the API supporting numeric protocols. |
|
@jaydub Thanks. Do you mind opening a new issue to track this? |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
issue: #12901