Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the check_id out parameter to circonus_check. #12832

Merged
merged 1 commit into from
Mar 17, 2017

Conversation

sean-
Copy link
Contributor

@sean- sean- commented Mar 17, 2017

This is an important optimization for dynamically created resources
via the count attribute.

I'm reasonably certain there will be a merge conflict with #12820 once #12820 is merged. If/when that happens, I will update this PR with the resolution.

This is an important optimization for dynamically created resources
via the `count` attribute.
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@grubernaut grubernaut merged commit 2c564f1 into master Mar 17, 2017
@grubernaut grubernaut deleted the f-circonus-check-check-id branch March 17, 2017 22:36
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants