Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the AWS Access Key and Secret Access keys from theconsul_agent_self data source. #12061

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

sean-
Copy link
Contributor

@sean- sean- commented Feb 17, 2017

Pro tip: update consul! I was using an old branch of Consul, not
origin/master.

Hat tip to @slackpad for pointing out that these keys were removed. Insta-merge to 0-8-stable after a review.

`consul_agent_self` data source.

Pro tip: update consul!  I was using an old branch of Consul, not
`origin/master`.
Copy link
Contributor

@grubernaut grubernaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sean- sean- merged commit 3127998 into master Feb 17, 2017
@sean- sean- deleted the b-aws-keys-removed branch February 17, 2017 21:36
sean- added a commit that referenced this pull request Feb 17, 2017
`consul_agent_self` data source.

Pro tip: update consul!  I was using an old branch of Consul, not
`origin/master`.
@ghost
Copy link

ghost commented Apr 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants