Upgrade ignore_changes wildcard from warning to error

The syntax ignore_changes = ["*"] was deprecated and now errors. Use = all instead.
hashicorp · Feb 19, 2021 · 230658f · 230658f
1 parent 3da5d2b
commit 230658f
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 17 deletions.
diff --git a/configs/resource.go b/configs/resource.go
@@ -211,9 211,9 @@ func decodeResourceBlock(block *hcl.Block) (*Resource, hcl.Diagnostics) {
  r.Managed.IgnoreAllChanges = true
  ignoreAllRange = expr.Range()
  diags = append(diags, &hcl.Diagnostic{
- Severity: hcl.DiagWarning,
- Summary: "Deprecated ignore_changes wildcard",
- Detail: "The [\"*\"] form of ignore_changes wildcard is deprecated. Use \"ignore_changes = all\" to ignore changes to all attributes.",
  Severity: hcl.DiagError,
  Summary: "Invalid ignore_changes wildcard",
  Detail: "The [\"*\"] form of ignore_changes wildcard is was deprecated and is now invalid. Use \"ignore_changes = all\" to ignore changes to all attributes.",
  Subject: attr.Expr.Range().Ptr(),
  })
  continue

diff --git a/configs/testdata/error-files/ignore_changes.tf b/configs/testdata/error-files/ignore_changes.tf
@@ -0,0 1,5 @@
 resource "null_resource" "all" {
  lifecycle {
  ignore_changes = ["*"] # ERROR: Invalid ignore_changes wildcard
  }
 }
diff --git a/configs/testdata/warning-files/ignore_changes.tf b/configs/testdata/warning-files/ignore_changes.tf
diff --git a/terraform/context_apply_test.go b/terraform/context_apply_test.go
@@ -8372,8 8372,8 @@ func TestContext2Apply_ignoreChangesWithDep(t *testing.T) {
  }
 }
 
-func TestContext2Apply_ignoreChangesWildcard(t *testing.T) {
- m := testModule(t, "apply-ignore-changes-wildcard")
 func TestContext2Apply_ignoreChangesAll(t *testing.T) {
  m := testModule(t, "apply-ignore-changes-all")
  p := testProvider("aws")
  p.PlanResourceChangeFn = testDiffFn
  p.ApplyResourceChangeFn = testApplyFn

diff --git a/...ata/apply-ignore-changes-wildcard/main.tf → ...testdata/apply-ignore-changes-all/main.tf b/...ata/apply-ignore-changes-wildcard/main.tf → ...testdata/apply-ignore-changes-all/main.tf
@@ -2,6 2,6 @@ resource "aws_instance" "foo" {
  required_field = "set"
 
  lifecycle {
- ignore_changes = ["*"]
  ignore_changes = all
  }
 }