New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve readability of member event coalescer #739

Open

mbver wants to merge 1 commit into hashicorp:master from mbver:coalesce-update-event

mbver commented Aug 20, 2024

lastEvents and latestEvents are easily confused with one another. recommend using newEvents. coalesceEvent is not descriptive of its role. it is event for a node, so call it nodeEvent.
using only event types for lastEvents is too clever and make the code harder to reason about. furthermore, it doesn't help in checking duplicating member-update-event. stick with nodeEvent for lastEvents and it handles duplication with ease.


          improve readability of member event coalescer. check update event in …

53c85c2

…flush.

mbver requested a review from a team as a code owner

August 20, 2024 14:22

mbver requested review from banks and removed request for a team

August 20, 2024 14:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet