Make config.Cmd and config.RunnerFunc mutually exclusive #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A set of small follow-ups to #270: * Make `config.Cmd` and `config.RunnerFunc` mutually exclusive. * Clients setting `RunnerFunc` can call `ReattachConfig` but need to supply their own `ReattachFunc` as it can't necessarily be derived from `RunnerFunc`. Exercise `ReattachConfig()` in tests in a way that previously panicked. * Improve 1 logger line for non-cmd implementations. * Add `ID()` function to client; allows clients to construct a `ReattachFunc` and also useful for client's debug log information.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of small follow-ups to #270:
ClientConfig.CmdandClientConfig.RunnerFuncmutually exclusiveRunnerFunccan callReattachConfig()but need to supply their ownReattachFuncas it can't necessarily be derived fromRunnerFunc. ExerciseReattachConfig()in tests in a way that previously panicked.ID()function to client; accommodates creating aReattachFuncand also useful for client's debug log information.