Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate service tags #2329

Open
ygersie opened this issue Sep 7, 2016 · 1 comment
Open

Prevent duplicate service tags #2329

ygersie opened this issue Sep 7, 2016 · 1 comment
Labels
theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature

Comments

@ygersie
Copy link

ygersie commented Sep 7, 2016

Hi,

I have a situation where I'm using nomad job templates provided by a service with custom tags. I've created a wrapper to be able to specify additional tags during deployment. Problem with that is that Consul allows duplicate tags (which makes sense as I expect tags are an array). This leads to pollution of service tags.

Wouldn't it be better to use a set instead of an array?

Btw, for now I'm just going to check member existence in my wrapper to prevent this but IMHO it would be nice if Consul already did that.

@slackpad slackpad added the type/enhancement Proposed improvement or new feature label Sep 21, 2016
@slackpad
Copy link
Contributor

Agree - we should dedup!

@slackpad slackpad added the theme/service-metadata Anything related to management/tracking of service metadata label May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/service-metadata Anything related to management/tracking of service metadata type/enhancement Proposed improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants