Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contextMenu options related to copy with headers aren't correctly described #11111

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

contextMenu options related to copy with headers aren't correctly described #11111

wants to merge 2 commits into from

Conversation

Skoczowianin
Copy link
Contributor

@Skoczowianin Skoczowianin commented Jul 24, 2024 •
edited
Loading

Context

Readers of the article Context menu with specific options should be informed that options copy_with_column_headers, copy_with_column_group_headers, copy_column_headers_only require additional enabling in the plugin configuration.

copyPaste: {
  copyColumnHeaders: true,
  copyColumnGroupHeaders: true,
  copyColumnHeadersOnly: true,
}

How has this been tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Related issue(s):

  1. #1917

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

[skip changelog]

@Skoczowianin Skoczowianin self-assigned this Jul 24, 2024
@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 24, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 38d33cd:

Sandbox Source
handsontable-javascript-demo Configuration
handsontable-typescript-demo Configuration
handsontable-react-demo Configuration
handsontable-vue-2-demo Configuration
handsontable-vue-3-demo Configuration
handsontable-angular-demo Configuration

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

Launch the local version of documentation by running:

npm run docs:review 38d33cd453508eeb0919d939ea71e654d6bf969d

@Skoczowianin Skoczowianin changed the title Docs: update docs for the contextMenu options requiring further config contextMenu options related to copy with headers aren't correctly described Jul 24, 2024
@Skoczowianin Skoczowianin added Docs: Content Issues related to Handsontable's documentation content Context menu Plugin labels Jul 24, 2024
@Skoczowianin Skoczowianin removed the request for review from jansiegel July 25, 2024 09:26
@krzysztofspilka
Copy link
Member

I'm not sure about the correctness of this change. Let's put it on hold until Aleksander has time to look into it.

@krzysztofspilka krzysztofspilka removed their request for review July 25, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianszymanski89 adrianszymanski89 adrianszymanski89 approved these changes

Assignees

@Skoczowianin Skoczowianin

Labels
Context menu Plugin Docs: Content Issues related to Handsontable's documentation content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skoczowianin @krzysztofspilka @adrianszymanski89