Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectionArea offset top issue #5

Closed
zhaoguobin opened this issue Apr 23, 2012 · 1 comment
Closed

selectionArea offset top issue #5

zhaoguobin opened this issue Apr 23, 2012 · 1 comment
Assignees
@warpech
Labels
Core: Selection Plugin Status: Released Type: Feature

Comments

@zhaoguobin
Copy link

My english is poor, hope you can understand to it:
in jquery.handsontable.js , highlight, on

containerOffset = last.parent().parent().offset();

I think it should be:

containerOffset = last.parent().parent().parent().parent().offset();

I think containerOffset should be the offset of $("#dataTable") ( or $("#dataTable2")...), not tbody.
I think you can store $("#dataTable") ( or $("#dataTable2")...) in priv,then you can write in this way:

containerOffset = priv.xxxx.offset();

Maybe I am wrong.

PS: This plugin is cool!
@warpech
Copy link
Member

warpech commented Apr 26, 2012

Thanks zhaoguobin, I think you are right! I will add this change within next few days.

Even simplier solution is possible:

containerOffset = container.offset();

@ghost ghost assigned warpech Apr 26, 2012
warpech added a commit that referenced this issue Aug 1, 2014
@warpech
This commit refs #5
bfaf7a8
zhouxiaoping pushed a commit to zhouxiaoping/handsontable that referenced this issue Oct 22, 2015
@pingyuanChen
Merge pull request handsontable#5 from pingyuanChen/py-custom-borders
fc063ad 
Py custom borders
evanSe pushed a commit that referenced this issue Feb 21, 2024
@NOtherDev
React wrapper: Change the way editor might be passed to HotColumn and…
0377646 
… HotTable to use render props approach (#10793)

* Change the way editor might be passed to HotColumn and HotTable to use render props approach (#5)

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warpech warpech

Labels
Core: Selection Plugin Status: Released Type: Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zhaoguobin @warpech @AMBudnik