Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.19] refactor: optimize request headers when generating thumbnails from URI #6633

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #6628

/assign JohnNiang

None

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link

f2c-ci-robot bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-2.19@a5ff816). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...tachment/reconciler/LocalThumbnailsReconciler.java 0.00% 2 Missing ⚠️
...re/attachment/reconciler/AttachmentReconciler.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.19    #6633    /-   ##
===============================================
  Coverage                ?   58.06%           
  Complexity              ?     3916           
===============================================
  Files                   ?      670           
  Lines                   ?    22974           
  Branches                ?     1576           
===============================================
  Hits                    ?    13341           
  Misses                  ?     9017           
  Partials                ?      616           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot merged commit 9ffb1bb into halo-dev:release-2.19 Sep 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants