Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip thumbnail generation for GIF images #6597

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 5, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.20.x

What this PR does / why we need it:

修复 GIF 缩略图生成只会保留第一帧的问题

Which issue(s) this PR fixes:

Fixes #6596

Does this PR introduce a user-facing change?

修复 GIF 缩略图生成只会保留第一帧的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 5, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 5, 2024
@halo-dev halo-dev deleted a comment from halo-dev-bot Sep 5, 2024
@guqing
Copy link
Member Author

guqing commented Sep 5, 2024

/cherry-pick release-2.19

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarcloud bot commented Sep 6, 2024

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.06%. Comparing base (6cd8dc8) to head (36bb93e).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
...n/halo/app/core/attachment/ThumbnailGenerator.java 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6597       /-   ##
============================================
- Coverage     58.18%   58.06%   -0.12%     
- Complexity     3774     3916      142     
============================================
  Files           651      670       19     
  Lines         22125    22966      841     
  Branches       1538     1575       37     
============================================
  Hits          12873    13335      462     
- Misses         8641     9015      374     
- Partials        611      616        5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2024
Copy link

f2c-ci-robot bot commented Sep 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 2ea063d into halo-dev:main Sep 6, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #6609

In response to this:

/cherry-pick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 6, 2024
This is an automated cherry-pick of #6597

/assign guqing

```release-note
修复 GIF 缩略图生成只会保留第一帧的问题
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gif 生成多尺寸图片时,会仅保留第一帧
4 participants