Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tiptap to 2.6.5 #6503

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 23, 2024

What type of PR is this?

/kind improvement
/area ui
/milestone 2.19.x

What this PR does / why we need it:

升级 tiptap 相关依赖至 2.6.5

Does this PR introduce a user-facing change?

升级 Tiptap 相关依赖至 [2.6.5](https://github.com/ueberdosis/tiptap/releases/tag/v2.6.5)

@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/improvement Categorizes issue or PR as related to a improvement. labels Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang August 23, 2024 06:42
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Aug 23, 2024
Copy link

sonarcloud bot commented Aug 23, 2024

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.22%. Comparing base (6cd8dc8) to head (10ab99b).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6503       /-   ##
============================================
  Coverage     58.18%   58.22%    0.04%     
- Complexity     3774     3775        1     
============================================
  Files           651      651              
  Lines         22125    22128        3     
  Branches       1538     1538              
============================================
  Hits          12873    12885       12     
  Misses         8641     8634       -7     
  Partials        611      609       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2024
Copy link

f2c-ci-robot bot commented Aug 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d9bc8cf into halo-dev:main Aug 23, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 25, 2024
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants