Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: previous and next post links included hidden posts #6491

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: previous and next post links included hidden posts #6491

merged 1 commit into from
Aug 22, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Aug 22, 2024

What type of PR is this?

/kind bug
/area core
/milestone 2.19.x

What this PR does / why we need it:

修复文章的上一篇下一篇链接包含了隐藏分类下的文章

Does this PR introduce a user-facing change?

修复文章的上一篇下一篇链接包含了隐藏分类下的文章

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Aug 22, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG August 22, 2024 03:49
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Aug 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen August 22, 2024 03:49
@codecov Codecov
Copy link

codecov bot commented Aug 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (6cd8dc8) to head (dec4462).
Report is 2 commits behind head on main.

Files Patch % Lines
...un/halo/app/theme/finders/impl/PostFinderImpl.java 50.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6491       /-   ##
============================================
  Coverage     58.18%   58.21%    0.03%     
  Complexity     3774     3774              
============================================
  Files           651      651              
  Lines         22125    22128        3     
  Branches       1538     1538              
============================================
  Hits          12873    12882        9     
  Misses         8641     8636       -5     
  Partials        611      610       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

JohnNiang
JohnNiang approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit d8ec34b into halo-dev:main Aug 22, 2024
8 checks passed
@guqing guqing deleted the fix/post-navigation branch August 22, 2024 08:40
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guqing @JohnNiang @ruibaby