Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use patch api to refactor menu drag-and-drop sorting feature #6462

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Aug 12, 2024

What type of PR is this?

/area ui
/kind improvement
/milestone 2.19.x

What this PR does / why we need it:

使用 patch 接口重构菜单项拖动排序等功能。

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

需要测试菜单项的拖动排序功能是否符合预期。

Does this PR introduce a user-facing change?

使用 patch 接口重构菜单项拖动排序功能。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/ui Issues or PRs related to the Halo UI labels Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 12, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and LIlGG August 12, 2024 04:42
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Aug 12, 2024
Copy link

sonarcloud bot commented Aug 12, 2024

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.27%. Comparing base (bc10336) to head (8be5593).
Report is 118 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6462       /-   ##
============================================
  Coverage     54.51%   58.27%    3.76%     
- Complexity     3523     3781      258     
============================================
  Files           646      651        5     
  Lines         21862    22138      276     
  Branches       1528     1555       27     
============================================
  Hits          11917    12900      983     
  Misses         9328     8616     -712     
- Partials        617      622        5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby
Copy link
Member Author

ruibaby commented Aug 12, 2024

@halo-dev/sig-halo 请帮忙检查一下 role template 是否加了 patch 类型的接口。

@guqing
Copy link
Member

guqing commented Aug 14, 2024

当只分配了菜单管理而没有系统配置权限时,菜单管理页面会因为 /api/v1alpha1/configmaps/system 403 而报错

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

works very well

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@guqing
Copy link
Member

guqing commented Aug 14, 2024

@halo-dev/sig-halo 请帮忙检查一下 role template 是否加了 patch 类型的接口。

权限正确

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
Copy link

f2c-ci-robot bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 7774eb1 into halo-dev:main Aug 16, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/menus branch August 16, 2024 16:44
@JohnNiang JohnNiang modified the milestones: 2.19.x, 2.19.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants