Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for previewing avif images in attachments #6446

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Aug 7, 2024

What type of PR is this?

/kind feature
/area ui
/milestone 2.19.x

What this PR does / why we need it:

支持在附件库中预览 image/avif 的图片。

Which issue(s) this PR fixes:

Fixes #6320

Does this PR introduce a user-facing change?

支持在附件库中预览 avif 类型的图片

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.19.x milestone Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Aug 7, 2024
Copy link

sonarcloud bot commented Aug 7, 2024

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.12%. Comparing base (bc10336) to head (4bd5484).
Report is 104 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6446       /-   ##
============================================
  Coverage     54.51%   58.12%    3.61%     
- Complexity     3523     3767      244     
============================================
  Files           646      651        5     
  Lines         21862    22106      244     
  Branches       1528     1555       27     
============================================
  Hits          11917    12850      933     
  Misses         9328     8633     -695     
- Partials        617      623        6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
Copy link

f2c-ci-robot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 457508f into halo-dev:main Aug 7, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.19.x, 2.19.0 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

希望附件库能够预览avif格式的图片
2 participants