Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove padding style from editor column block #6407

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jul 29, 2024

What type of PR is this?

/area editor
/kind improvement
/milestone 2.18.x

What this PR does / why we need it:

移除编辑器 Column 的默认 padding 样式。

See #6377 (comment)

Which issue(s) this PR fixes:

Fixes #6377

Does this PR introduce a user-facing change?

移除编辑器分栏卡片的默认 padding 样式。

@f2c-ci-robot f2c-ci-robot bot added area/editor Issues or PRs related to the Editor release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.18.x milestone Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen July 29, 2024 07:58
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.30%. Comparing base (bc10336) to head (aedb4ad).
Report is 89 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6407       /-   ##
============================================
  Coverage     54.51%   58.30%    3.79%     
- Complexity     3523     3764      241     
============================================
  Files           646      646              
  Lines         21862    21989      127     
  Branches       1528     1546       18     
============================================
  Hits          11917    12821      904     
  Misses         9328     8545     -783     
- Partials        617      623        6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2b32715 into halo-dev:main Jul 29, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

移除编辑器中 Column 布局的默认边距
3 participants