Add before and after security web filters #6297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
release-note
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6297 /- ##
============================================
Coverage 54.51% 58.28% 3.77%
- Complexity 3523 3763 240
============================================
Files 646 647 1
Lines 21862 21967 105
Branches 1528 1541 13
============================================
Hits 11917 12804 887
Misses 9328 8545 -783
- Partials 617 618 1 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
/area core
/area plugin
What this PR does / why we need it:
This PR adds
BeforeSecurityWebFilterandAfterSecurityWebFilterextension points. See halo-sigs/plugin-page-cache#4 (comment) for more.Now, we can do something before and after authenticating.
Does this PR introduce a user-facing change?