Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support obtaining plugins root in plugins #6269

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Support obtaining plugins root in plugins #6269

merged 1 commit into from
Jul 4, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind feature
/kind api-change
/area core
/area plugin

What this PR does / why we need it:

This PR supports obtaining plugins root in plugins. Below is an example in plugin:

@Component
class PluginsRootGetterDemo {

    private final PluginsRootGetter pluginsRootGetter;

    PluginsRootGetterDemo(PluginsRootGetter pluginsRootGetter) {
        this.pluginsRootGetter = pluginsRootGetter;
    }

}

Meanwhile, I remove the PluginProperties#pluginsRoot for a clear way to obtain plugins root.

Does this PR introduce a user-facing change?

支持在插件中获取插件根目录

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen July 4, 2024 10:52
@f2c-ci-robot f2c-ci-robot bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider labels Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.26%. Comparing base (bc10336) to head (57a63e1).
Report is 62 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6269       /-   ##
============================================
  Coverage     54.51%   58.26%    3.75%     
- Complexity     3523     3759      236     
============================================
  Files           646      647        1     
  Lines         21862    21950       88     
  Branches       1528     1541       13     
============================================
  Hits          11917    12790      873     
  Misses         9328     8542     -786     
- Partials        617      618        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruibaby
ruibaby approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit ad66247 into halo-dev:main Jul 4, 2024
7 checks passed
@JohnNiang JohnNiang deleted the feat/support-get-plugins-root-in-plugin branch July 4, 2024 13:36
@ruibaby ruibaby added this to the 2.18.0 milestone Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core area/plugin Issues or PRs related to the Plugin Provider kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnNiang @ruibaby