Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictation and grammar corrections for chapters 1-4 #776

Merged
merged 8 commits into from
Oct 3, 2020
Merged

Dictation and grammar corrections for chapters 1-4 #776

merged 8 commits into from
Oct 3, 2020

Conversation

salmasian
Copy link
Contributor

This includes several minor changes to grammar or dictation, as well as the addition of a link for the hashtag search on Twitter.

Even though Garrett is a coauthor of this book, specifying his last name would be appropriate.
Since eval is set to True, this already outputs the `#> [1] 3` and that line makes it show twice in the book which is not what is desired here.
This book has two authors (Hadley and Garrett), if not more :) Therefore, the pronoun should be in plural form
This book has two authors (Hadley and Garrett), if not more :) Therefore, the pronoun should be in plural form
@salmasian
Copy link
Contributor Author

CI seems to have failed for reasons unrelated to this change:

Quitting from lines 296-297 (intro.Rmd) 
Error in loadNamespace(name) : there is no package called 'devtools'

@salmasian salmasian closed this Apr 27, 2019
@salmasian salmasian reopened this Apr 27, 2019
@salmasian salmasian closed this Jun 16, 2019
@salmasian salmasian reopened this Jun 16, 2019
intro.Rmd Outdated
@@ -95,7 95,7 @@ It's common to think about modelling as a tool for hypothesis confirmation, and

## Prerequisites

We've made a few assumptions about what you already know in order to get the most out of this book. You should be generally numerically literate, and it's helpful if you have some programming experience already. If you've never programmed before, you might find [Hands on Programming with R](http://amzn.com/1449359019) by Garrett to be a useful adjunct to this book.
We've made a few assumptions about what you already know in order to get the most out of this book. You should be generally numerically literate, and it's helpful if you have some programming experience already. If you've never programmed before, you might find [Hands on Programming with R](http://amzn.com/1449359019) by Garrett Grolemund to be a useful adjunct to this book.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree. We are writing in a friendly, conversational tone—one that invites the reader to be on a first name basis with the authors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. I will undo this one.

@hadley hadley merged commit b12102f into hadley:master Oct 3, 2020
@hadley
Copy link
Owner

hadley commented Oct 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants