Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafe blocks #417

Closed
W95Psp opened this issue Jan 5, 2024 · 5 comments
Closed

unsafe blocks #417

W95Psp opened this issue Jan 5, 2024 · 5 comments
Labels
unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon. wontfix-v1 This will not be worked on, but might after v1.

Comments

@W95Psp
Copy link
Collaborator

W95Psp commented Jan 5, 2024

We don't plan to support unsafe blocks.

@W95Psp W95Psp added wontfix This will not be worked on unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon. labels Jan 5, 2024
@W95Psp W95Psp closed this as completed Jan 5, 2024
@W95Psp W95Psp reopened this Jan 5, 2024
@W95Psp W95Psp added wontfix-v1 This will not be worked on, but might after v1. and removed wontfix This will not be worked on labels Jan 5, 2024
Copy link

github-actions bot commented Oct 1, 2024

This issue has been marked as stale due to a lack of activity for 60 days. If you believe this issue is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale label Oct 1, 2024
@franziskuskiefer
Copy link
Member

Great timing of the bot, this should also go on https://github.com/cryspen/home/issues/95 I suppose @W95Psp

@github-actions github-actions bot removed the stale label Oct 2, 2024
@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

Basic support was added in #867.
I suppose now the question is: what do we do with unsafe blobs? Shall we just extract them as is? That's probably fine, unsafe is just a marker, at the end, performing an unsafe operation resolve to (1) calling unsafe functions or (2) raw pointers. We still reject raw pointers right away, and unsafe functions are just normal functions that usually make strong assumptions, which we can model precisely with strong preconditions

I wonder if we should just turn the unsafe feature on in the F* backend then. Wdyt @franziskuskiefer?

@franziskuskiefer
Copy link
Member

Sure, let's turn it on for F* and see what happens.
Is more needed than the basic support? If so, please update the issue on what remains unsupported and what's supported. If not, let's close this.

@W95Psp
Copy link
Collaborator Author

W95Psp commented Oct 2, 2024

No, more advanced support would mean library support in the backends, so we should close that issue.
Ok! Will push a PR, it's gonna be a very small PR.

@W95Psp W95Psp closed this as completed Oct 2, 2024
W95Psp added a commit that referenced this issue Oct 2, 2024
This PR follows from
#417 (comment), and
from PR #867.

It turns on the `unsafe` feature for the F* backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unsupported-rust Rust code rejected by hax. Unless marked wontfix, we want to support it soon. wontfix-v1 This will not be worked on, but might after v1.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants