Skip to content
This repository has been archived by the owner on Jan 24, 2022. It is now read-only.

404 page crashes when loaded from non-existent page #397

Closed
alchzh opened this issue Aug 23, 2018 · 7 comments
Closed

404 page crashes when loaded from non-existent page #397

alchzh opened this issue Aug 23, 2018 · 7 comments

Comments

@alchzh
Copy link

alchzh commented Aug 23, 2018

2018-08-22-183246_1174x746_scrot

t is theme. Does not occur when accessing http://hackclub.com/404.html .

@zachlatta
Copy link
Member

macsie_firefox_61 0

Can't repro on Sierre w/ Firefox 61 & uBlock Origin installed. Which OS and browser version do you have? Any other addons that might be messing with stuff?

Do you still run into the issue in a private window w/o cache? Wonder if it's a caching issue.

@alchzh
Copy link
Author

alchzh commented Aug 23, 2018

I think the problem is that I'm not redirecting to 404.html properly, I'll look into it...

Edit: I got the same error using qutebrowser (WebEngine based) with no modifications. Checking if system settings might be messing it up?

@zachlatta
Copy link
Member

Yup, can repro on that. Here's what I was able to do (cc @lachlanjc).

  1. Open new Firefox 61 on Sierra through BrowserStack
  2. Install uBlock Origin addon (Raymond Hill version)
  3. Go to https://hackclub.com/notarealpage

@joshkmartinez
Copy link
Member

joshkmartinez commented Aug 26, 2018

This happens on Chrome too with ublock origin.
screen shot 2018-08-26 at 2 01 48 pm

@MatthewStanciu
Copy link
Member

This happens for me on everything I try to access it on, including Chrome and Firefox with and without uBlock Origin, and on my iPhone. I don't think it's directly related to uBlock Origin or Firefox. The only difference I see is that on Chrome the error says "3" is undefined, but on Firefox it says "t.space" is undefined.

@joshkmartinez
Copy link
Member

Its this line in the Nav.js component that's throwing the error for all of us: padding-left: ${({ theme }) => theme.space[3]}px; (line 36)

@alchzh alchzh changed the title 404 page crashes when loaded from non-existent page in Firefox 404 page crashes when loaded from non-existent page Sep 10, 2018
@maxwofford
Copy link
Member

The page works fine for me (think this may have been fixed in one of @lachlanjc's recent updates). Closing, but comment here if you see it again

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants