Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM and CJS dual package support #1963

Merged
merged 7 commits into from
Oct 25, 2023
Merged

ESM and CJS dual package support #1963

merged 7 commits into from
Oct 25, 2023

Conversation

h3poteto
Copy link
Owner

@h3poteto h3poteto commented Oct 8, 2023

No description provided.

@h3poteto h3poteto marked this pull request as ready for review October 8, 2023 04:54
This was referenced Oct 8, 2023
Draft
Draft
Closed
ThatOneCalculator
ThatOneCalculator reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@ThatOneCalculator ThatOneCalculator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe browser should be changed to webpack, since both Webpack and Vite target the browser

megalodon/tsconfig.mjs.json Outdated Show resolved Hide resolved
@h3poteto h3poteto merged commit 2e26d36 into master Oct 25, 2023
13 checks passed
@h3poteto h3poteto deleted the try/dual-package branch October 25, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThatOneCalculator ThatOneCalculator ThatOneCalculator left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h3poteto @ThatOneCalculator