Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use PNPM instead of Yarn & Vite instead of Webpack #1951

Draft
wants to merge 21 commits into
base: master
Choose a base branch
from
Draft

refactor: use PNPM instead of Yarn & Vite instead of Webpack #1951

wants to merge 21 commits into from

Conversation

ThatOneCalculator
Copy link
Contributor

Supersedes #1937

@h3poteto
Copy link
Owner

h3poteto commented Oct 4, 2023

Why do example tests fail?

@ThatOneCalculator
Copy link
Contributor Author

I'm not sure 🤔

@ThatOneCalculator ThatOneCalculator marked this pull request as draft October 7, 2023 23:30
@ThatOneCalculator ThatOneCalculator marked this pull request as ready for review October 7, 2023 23:39
@ThatOneCalculator ThatOneCalculator changed the title use pnpm instead of yarn use pnpm instead of yarn and vite instead of webpack Oct 7, 2023
@ThatOneCalculator ThatOneCalculator changed the title use pnpm instead of yarn and vite instead of webpack refactor: use PNPM instead of Yarn & Vite instead of Webpack Oct 7, 2023
@ThatOneCalculator ThatOneCalculator mentioned this pull request Oct 8, 2023
Draft
@ThatOneCalculator ThatOneCalculator marked this pull request as draft October 8, 2023 00:21
@ThatOneCalculator ThatOneCalculator marked this pull request as ready for review October 8, 2023 00:49
@ThatOneCalculator
Copy link
Contributor Author

ThatOneCalculator commented Oct 8, 2023 •
edited
Loading

@h3poteto The weird cjs workaround should be fixed by #1961 , but for now, this works. Also, bundling the browser example with Vite instead of Webpack gives better build times too

@ThatOneCalculator
Copy link
Contributor Author

Drafting until #1963 is merged

@ThatOneCalculator ThatOneCalculator marked this pull request as draft October 8, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3poteto h3poteto Awaiting requested review from h3poteto h3poteto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatOneCalculator @h3poteto