Add closest-match logic adapter #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 1,94 @@ | |||
| from .logic import LogicAdapter | |||
| from collections import Counter | |||
| import nltk | |||
There was a problem hiding this comment.
In your tests you should be installing nltk, and you probably want to guard against the ImportError here and raise a useful message.
No need to require it in your setup.py, as it's only needed for this adapter.
gunthercox
force-pushed
the
closest_meaning
branch
5 times, most recently
from
0e5900d
to
cc9f7bd
Compare
gunthercox
force-pushed
the
closest_meaning
branch
2 times, most recently
from
1fc7db1
to
22c4da5
Compare
I've started looking into using nltk to compare two statements by the meaning of their content. This branch is currently in a work in progress state.
gunthercox
force-pushed
the
closest_meaning
branch
from
22c4da5
to
780635f
Compare
gunthercox
added a commit
that referenced
this pull request
Sep 12, 2015
Add closest-match logic adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've started looking into using NLTK to compare two statements by the meaning of their content.
Closest Match