Fixing "Conversation 2" label #2026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing number of lines, as the project's pattern
gunthercox
requested changes
Apr 1, 2021
There was a problem hiding this comment.
It looks like this change might have modified the vector graphic from being a collection of vector elements into being an embedded base64 encoded image. I kind of prefer the elements since they seem cleaner and more easily editable.
What was this pull request suppose to fix, it isn't clear in the provided description?
|
You are right @gunthercox it seem cleaner and more easily editable, but look at the image from your repo https://github.com/gunthercox/ChatterBot/blob/master/docs/_static/training-graph.svg and the image from my pull request, at the second block you repeated the label "Conversation 1", I fixed this label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second block was repeating the label "Conversation 1",
As you can see, I fixed it as "Conversation 2" and converted into a SVG file as the previous one.