Use SwiftProtobuf's new CodeGenerator interface #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SwiftProtobuf 1.27.0 added a new `CodeGenerator` interface in 1.27.0 and deprecated the old API. This didn't include (non-deprecated) access to the source proto which is required for reflection data, however, this was added in 1.28.0. Modification: - Rename `options.swift` to `Options.swift` - Rewrite `main` as `GenerateGRPC`, the functionality is unchanged but did require a bit of code shuffling. As part of this some global methods became private methods on the new `GenerateGRPC` `struct`. - Add support for protobuf editions. Result: - Fewer warnings - Can use protobuf editions
gjcairo
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftProtobuf 1.27.0 added a new
CodeGeneratorinterface in 1.27.0 and deprecated the old API. This didn't include (non-deprecated) access to the source proto which is required for reflection data, however, this was added in 1.28.0.Modification:
options.swifttoOptions.swiftmainasGenerateGRPC, the functionality is unchanged but did require a bit of code shuffling. As part of this some global methods became private methods on the newGenerateGRPCstruct.Result: