Save two allocations by making MapRPCWriter and SerializingRPCWriter generic over wrapped writer
#1983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We currently wrap a base writer into an
RPCWriterinside theMapRPCWriterandSerializingRPCWriter.This results in an unnecessary allocation in both cases. In the case of unary requests, this means two extra allocations per requests on the client side.
Modifications
Make the
MapRPCWriterandSerializingRPCWritergeneric over the base writer, to avoid the extra allocations caused by wrapping them in anRPCWriter.Result
Two fewer allocations per unary request on the client side.