Avoid an error allocation in the server stream handler #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Existential errors unconditionally allocate. In the server stream handler a promise is failed on tear down via an API which takes an existential error. This means the handler always allocates, even if the promise has been completed. Modifications: - Statically allocate the error as an existential Result: Fewer allocations
gjcairo
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Existential errors unconditionally allocate. In the server stream handler a promise is failed on tear down via an API which takes an existential error. This means the handler always allocates, even if the promise has been completed.
Modifications:
Result:
Fewer allocations