Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary CoWs in server state machine #1969

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Avoid unnecessary CoWs in server state machine #1969

merged 1 commit into from
Jul 5, 2024

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jul 5, 2024

Motivation:

The server connection management state machine unnecessarily CoWs when streams are opened and closed.

Modifications:

  • Add a _modifying state and switch to it before modifying the streams set

Result:

Fewer allocations

@glbrntt
Avoid unnecessary CoWs in server state machine
bc0737f 
Motivation:

The server connection management state machine unnecessarily CoWs when
streams are opened and closed.

Modifications:

- Add a `_modifying` state and switch to it before modifying the streams
  set

Result:

Fewer allocations
@glbrntt glbrntt added the v2 A change for v2 label Jul 5, 2024
@glbrntt glbrntt requested a review from gjcairo July 5, 2024 09:44
@glbrntt glbrntt merged commit b9b4711 into grpc:main Jul 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjcairo gjcairo gjcairo approved these changes

Assignees
No one assigned
Labels
v2 A change for v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @gjcairo