Synthesise status when stream closes unexpectedly #1953
Conversation
gjcairo
force-pushed
the
synthetize-status
branch
from
4fa47f6
to
edac48f
Compare
| private func getServerUnexpectedInboundCloseAction( | ||
| for reason: UnexpectedInboundCloseReason | ||
| ) -> OnUnexpectedInboundClose { |
There was a problem hiding this comment.
Any reason this shouldn't be an init on OnUnexpectedInboundClose?
There was a problem hiding this comment.
Hmm I ended up doing this here because we're using this on the server side only (whereas the type itself is also used on the client side logic). But that's probably a not good enough reason, so I can move it.
| import XCTest | ||
|
|
||
| @testable import GRPCHTTP2Core | ||
| @testable import NIOHTTP2 |
There was a problem hiding this comment.
We really shouldn't do this because we're taking a dependency on the internal API of a module we don't own.
There was a problem hiding this comment.
Hm yes true - we should probably make the constructor public on NIO though, otherwise this API is unusable.
| case .doNothing: | ||
| context.fireErrorCaught(error) |
There was a problem hiding this comment.
Hmm, is doNothing the right name here? It's a bit confusing that do nothing fires an error here.
gjcairo
force-pushed
the
synthetize-status
branch
from
9eb1d5e
to
ab85075
Compare
Motivation
When the stream closes unexpectedly (the H2 stream channel becomes inactive, an error is fired through the pipeline, or we receive a RST_STREAM frame), the client-side inbound sequence either finishes or throws an error.
To make it easier for higher layers to retry, we want to synthesise a
Statusinstead.Modifications
Statuswhen one of the aforementioned unexpected closures happens.Result
Inbound sequence now returns a
Statusinstead of finishing/throwing