Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/2 transport integration tests #1948

Merged
merged 9 commits into from
Jun 25, 2024
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jun 21, 2024

Motivation:

The http/2 transports are only tested via unit tests.

Modifications:

  • Add a number of integration tests for the HTTP/2 transports

Result:

Better test coverage

Motivation:

The http/2 transports are only tested via unit tests.

Modifications:

- Add a number of integration tests for the HTTP/2 transports

Result:

Better test coverage
@glbrntt glbrntt requested a review from gjcairo June 21, 2024 14:55
@glbrntt glbrntt added the v2 A change for v2 label Jun 21, 2024
Motivation:

The http/2 transports are only tested via unit tests.

Modifications:

- Add a number of integration tests for the HTTP/2 transports

Result:

Better test coverage
}
}

func forEachClientAndHTTPStatusServer(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func forEachClientAndHTTPStatusServer(
func forEachClientAndHTTPStatusCodeServer(

Tests/GRPCHTTP2TransportTests/HTTP2TransportTests.swift Outdated Show resolved Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportTests.swift Outdated Show resolved Hide resolved
@glbrntt glbrntt requested a review from gjcairo June 24, 2024 16:40
@glbrntt glbrntt merged commit 1156333 into grpc:main Jun 25, 2024
17 checks passed
@glbrntt glbrntt deleted the h2-transport-tests branch June 25, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 A change for v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants