Enable SwiftPM build plugin to use the new code generator plugin #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jun 18, 2024
Plugins/GRPCSwiftPlugin/plugin.swift
Outdated
Comment on lines
232
to
235
| if let v2 { | ||
| protocArgs.append("--grpc-swift_opt=_V2=\(v2)") | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you move this up to where the other protoc args are prepared?
clintonpi
force-pushed
the
port-over-swiftpm-build-plugin
branch
from
092eeb4
to
1daa6c6
Compare
glbrntt
requested changes
Jun 18, 2024
Plugins/GRPCSwiftPlugin/plugin.swift
Outdated
Comment on lines
89
to
90
| /// Whether this configuration is for `grpc-swift` v2. | ||
| var _V2: Bool? |
There was a problem hiding this comment.
Sorry, I didn't missed this the first time around but this should be part of the Invocation configuration struct above
Motivation: The SwiftPM build plugin could not be configured to use the new code generator plugin. Modifications: - Add a `_V2` boolean option to the SwiftPM build plugin configuration. If this option is set, it is passed to protoc-gen-grpc-swift which then uses the new code generator plugin. Result: The SwiftPM build plugin can now be configured use the new code generator plugin.
clintonpi
force-pushed
the
port-over-swiftpm-build-plugin
branch
from
bcd1aff
to
df35a10
Compare
glbrntt
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The SwiftPM build plugin could not be configured to use the new code generator plugin.
Modifications:
_V2boolean option to the SwiftPM build plugin configuration. If this option is set, it is passed to protoc-gen-grpc-swift which then uses the new code generator plugin.Result:
The SwiftPM build plugin can now be configured use the new code generator plugin.