Expose listening address on HTTP2 server transport #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
commented
Jun 14, 2024
| @available(macOS 14.0, iOS 17.0, watchOS 10.0, tvOS 17.0, *) | ||
| public struct Posix: ServerTransport { | ||
| private let address: GRPCHTTP2Core.SocketAddress | ||
| private let config: Config | ||
| private let eventLoopGroup: MultiThreadedEventLoopGroup | ||
| private let serverQuiescingHelper: ServerQuiescingHelper | ||
|
|
||
| private let listeningAddressPromise: | ||
| _LockedValueBox<EventLoopPromise<GRPCHTTP2Core.SocketAddress>> |
There was a problem hiding this comment.
This is slightly annoying, but I backed this by a box containing the promise because I didn't want to make listen a mutating func, and I need to mutate the promise when we exit listen's scope.
glbrntt
requested changes
Jun 14, 2024
Sources/GRPCHTTP2TransportNIOPosix/GRPCHTTP2TransportNIOPosix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/GRPCHTTP2TransportNIOPosix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/GRPCHTTP2TransportNIOPosix.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
server-transport-expose-listening-addr
branch
from
f129b33
to
13de732
Compare
glbrntt
requested changes
Jun 14, 2024
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
glbrntt
requested changes
Jun 18, 2024
Sources/GRPCHTTP2Core/Internal/NIOSocketAddress GRPCSocketAddress.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2Core/Internal/NIOSocketAddress GRPCSocketAddress.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2Core/Internal/NIOSocketAddress GRPCSocketAddress.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportNIOPosixTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportNIOPosixTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportNIOPosixTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportNIOPosixTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
gjcairo
force-pushed
the
server-transport-expose-listening-addr
branch
from
2d45390
to
092dbd3
Compare
gjcairo
force-pushed
the
server-transport-expose-listening-addr
branch
from
092dbd3
to
0e2203a
Compare
glbrntt
requested changes
Jun 18, 2024
Sources/GRPCHTTP2TransportNIOPosix/HTTP2ServerTransport Posix.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
Tests/GRPCHTTP2TransportTests/HTTP2TransportNIOPosixTests.swift
Outdated
Show resolved
Hide resolved
clintonpi
pushed a commit
to clintonpi/grpc-swift
that referenced
this pull request
Jun 18, 2024
Motivation: We should expose the listening address on the H2 server transports so that our client can connect to it. Modifications: Exposed a `listeningAddress` async property. It will block until we bind or error, return the listening address while it's bound and listening, and throw an error when it's not listening anymore. Result: We can now know what address our server transport's listening on for requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We should expose the listening address on the H2 server transports so that our client can connect to it.
Modifications
Exposed a
listeningAddressasync property. It will block until we bind or error, return the listening address while it's bound and listening, and throw an error when it's not listening anymore.Result
We can now know what address our server transport's listening on for requests.