Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/grpcsync: Provide an internal-only pub-sub type API #6167

Merged
merged 17 commits into from
Jun 30, 2023
Merged

internal/grpcsync: Provide an internal-only pub-sub type API #6167

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift click to select a range
dd64d1d
add genericpubsub package and implementation
my4-dev Apr 1, 2023
fdbf826
add test file and fix bugs in genericpubsub
my4-dev Apr 3, 2023
4f83a06
move pubsub from genericpubsub to grpcsync
my4-dev Apr 4, 2023
9e14b9f
Change from Tracker to PubSub
my4-dev Apr 6, 2023
d5733fd
Update PubSub struct comment
my4-dev Apr 8, 2023
b6f2843
rename OnChange to OnMessage
my4-dev Apr 8, 2023
c48bce5
apply comments
my4-dev Apr 8, 2023
42ecca3
resolve race conditions and fix comments
my4-dev Apr 11, 2023
85edc36
Add some documentation
my4-dev Apr 11, 2023
cb33958
Add name to func returned by Subscribe
my4-dev Apr 11, 2023
9a6926f
fix tests
my4-dev Apr 11, 2023
6a7abc7
revise some documents and fix test coding style
my4-dev Apr 12, 2023
caf61f1
fix test style
my4-dev Apr 15, 2023
ba553b5
address all comments
my4-dev May 7, 2023
4b5033d
fix not to use bloking send in test cases
my4-dev May 11, 2023
8b6bd43
fix the test according to some advice
my4-dev Jun 27, 2023
cb3d134
Merge branch 'master' into generic-pub-sub-api
my4-dev Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add some documentation
  • Loading branch information
@my4-dev
my4-dev committed Apr 11, 2023
commit 85edc36b90ca7525c2105208f61dc800ba39db79
3 changes: 2 additions & 1 deletion internal/grpcsync/pubsub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 27,8 @@ import (
// a PubSub. It wraps the callback to be invoked by the PubSub when a new
// message is published.
type Subscriber interface {
// OnMessage is invoked to when a new message is published.
// OnMessage is invoked to when a new message is published. Implementations
easwars marked this conversation as resolved.
Show resolved Hide resolved
// must not block in this method.
OnMessage(msg interface{})
}

Expand Down