move pubsub from genericpubsub to grpcsync

and rename it to pubsub
grpc · arvindbr8 · Jun 30, 2023 · Apr 1, 2023 · Apr 3, 2023 · Apr 4, 2023
commit 4f83a06b5b77afd7e8b1171e8bc90bcad638f1eb
diff --git a/internal/genericpubsub/genericpubsub.go → internal/grpcsync/pubsub.go b/internal/genericpubsub/genericpubsub.go → internal/grpcsync/pubsub.go
@@ -16,15  16,11 @@
  *
  */
 
-// Package genericpubsub provides functionality to report and track
-// target changes of struct which is registered as a subscriber.
-package genericpubsub
 package grpcsync
 
 import (
 	"context"
 	"sync"
-
-	"google.golang.org/grpc/internal/grpcsync"
 )
 
 // Watcher wraps the functionality to be implemented by components
@@ -43,7  39,7 @@ type Watcher interface {
 // Components interested in target updates of the tracked entity
 // subscribe to updates by calling the AddWatcher() method.
 type Tracker struct {
-	cs     *grpcsync.CallbackSerializer
 	cs     *CallbackSerializer
 	cancel context.CancelFunc
 
 	// Access to the below fields are guarded by this mutex.
@@ -58,7  54,7 @@ type Tracker struct {
 func NewTracker(target interface{}) *Tracker {
 	ctx, cancel := context.WithCancel(context.Background())
 	return &Tracker{
-		cs:       grpcsync.NewCallbackSerializer(ctx),
 		cs:       NewCallbackSerializer(ctx),
 		cancel:   cancel,
 		target:   target,
 		watchers: map[Watcher]bool{},

diff --git a/internal/genericpubsub/genericpubsub_test.go → internal/grpcsync/pubsub_test.go b/internal/genericpubsub/genericpubsub_test.go → internal/grpcsync/pubsub_test.go
@@ -16,25  16,16 @@
  *
  */
 
-package genericpubsub
 package grpcsync
 
 import (
 	"sync"
 	"testing"
 	"time"
 
 	"github.com/google/go-cmp/cmp"
-	"google.golang.org/grpc/internal/grpctest"
 )
 
-type s struct {
-	grpctest.Tester
-}
-
-func Test(t *testing.T) {
-	grpctest.RunSubTests(t, s{})
-}
-
 type mockWatcher struct {
 	mu      sync.Mutex
 	t       *testing.T